r403 Duplicate SIP Extensions

[devon]

r403 allows creation of duplicate sip extensions. After looking through /usr/local/www/phones_sip_edit.php I can see that it looks for a match in an array built by function 'pbx_get_extensions' in /etc/inc/pbx.inc which calls function 'sip_get_extensions' in /etc/inc/sip.inc. Should the strings highlighted below in red be 'phone' instead of 'phones'?


/**
 * Returns an array of all assigned phone extensions
 */
function sip_get_extensions() {
   global $config;
   
   $extensions = array();

   if (is_array($config['sip']['phones'])) {
      foreach($config['sip']['phones'] as $phone) {
         $extensions[] = $phone['extension'];
      }
   }

   return $extensions;
}

[Michael]

Nice find, thanks! All of the phones' extensions were being gathered incorrectly (stupid copy and paste). I've changed them for the next image. Some work is still needed to properly check for duplicate extensions system-wide.